Extend VMWare image provisioning documentation #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh - extend finish information as new bullet point
|
If my way of documentation is ok, I can add it to latest, too. In future, should I do this the other way round? (first latest, then 1.x) |
|
@ezr-ondrej can you please take a look? |
ezr-ondrej
reviewed
Jan 28, 2020
|
Ok I will do an update to the latest documentation, too. I will take the new fancy words for that :) |
|
What's the status? |
Co-authored-by: Ondřej Ezr <[email protected]>
lzap
approved these changes
Mar 17, 2022
|
Okay this needs to be rebased and single commit and the change must be done against the nightly file, can you do that please? diff --git a/_includes/manuals/nightly/5.2.8_cr_vmware.md b/_includes/manuals/nightly/5.2.8_cr_vmware.md
index fcb79a736..12d4ee561 100644
--- a/_includes/manuals/nightly/5.2.8_cr_vmware.md
+++ b/_includes/manuals/nightly/5.2.8_cr_vmware.md
@@ -17,6 +17,7 @@ The same process can also be done using a user_data template. To configure image
* Browse then to the image to be used for provisioning, and ensure that "User Data" is checked
* Associate a user_data template to the host. The template will use cloud-init syntax.
* Note that the images don't need cloudinit installed, as the cloudinit is converted under the hood to a CustomisationSpec object that VMware can process
+* In order to inform foreman about successful build and get the host to "Installed" state in the UI, the provisioned host have to run a finish script. You canThanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend VMWare documentation. Image provisioning information without ssh - extend finish information as new bullet point